Github user vasia closed the pull request at:
https://github.com/apache/flink/pull/1600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1600#issuecomment-182957377
It's all green :D Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1600#issuecomment-182872698
@fhueske I fixed the aggregation hashCode and enables the ignored tests.
Let me know if it's OK now!
---
If your project is set up for it, you can reply to this email and
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1600#issuecomment-182817751
Looks pretty good. Can you check the `@Ignore` annotations?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1600#issuecomment-182392029
I've rebased this one on top of `tableOnCalcite` which includes #1595.
Regarding the average aggregate, I went for @tillrohrmann's suggestion of
adding 0.5. That m
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52349128
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AvgAggregate.scala
---
@@ -0,0 +1,145 @@
+/*
+
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52320399
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AvgAggregate.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Lice
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52306203
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MinAggregate.scala
---
@@ -0,0 +1,86 @@
+/*
+ * Lic
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52306088
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AvgAggregate.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52306136
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MaxAggregate.scala
---
@@ -0,0 +1,84 @@
+/*
+ * Lic
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52305988
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MinAggregate.scala
---
@@ -0,0 +1,86 @@
+/*
+ * Lic
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52305236
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataset/DataSetJoinRule.scala
---
@@ -39,6 +46,10 @@ class DataSet
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52304994
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataset/DataSetAggregateRule.scala
---
@@ -37,14 +39,24 @@ class D
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52304432
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/logical/FlinkAggregate.scala
---
@@ -58,19 +58,23 @@ class FlinkAg
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1600#issuecomment-181794348
Thanks for the feedback @tillrohrmann, @twalthr!
I've moved the classes to `org.apache.flink.api.table.runtime` and tried to
shorten the aggregates code using Numerics.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52225586
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/functions/aggregate/SumAggregate.scala
---
@@ -0,0 +1,130 @@
+/*
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52225277
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/functions/AggregateFunction.scala
---
@@ -0,0 +1,76 @@
+/*
+ * L
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52204752
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/functions/aggregate/SumAggregate.scala
---
@@ -0,0 +1,130 @@
+/*
+
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52192844
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/functions/AggregateFunction.scala
---
@@ -0,0 +1,76 @@
+/*
+ * Lic
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52192508
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/logical/FlinkAggregate.scala
---
@@ -58,19 +58,23 @@ class FlinkAggr
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52192307
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/functions/aggregate/MaxAggregate.scala
---
@@ -0,0 +1,136 @@
+/*
+
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52190250
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/functions/aggregate/SumAggregate.scala
---
@@ -0,0 +1,130 @@
+/*
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52181382
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/functions/aggregate/SumAggregate.scala
---
@@ -0,0 +1,130 @@
+/
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52176834
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/functions/AggregateFunction.scala
---
@@ -0,0 +1,76 @@
+/*
+ * L
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52175960
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/logical/FlinkAggregate.scala
---
@@ -58,19 +58,23 @@ class Fl
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52175572
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/functions/aggregate/MaxAggregate.scala
---
@@ -0,0 +1,136 @@
+/
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52175496
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/functions/aggregate/MaxAggregate.scala
---
@@ -0,0 +1,136 @@
+/
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/1600
[FLINK-3226] Translate logical aggregations to physical
This PR builds on #1567 and addresses @fhueske's comments on translating
aggregations.
Join translation is not part of this PR.
You can mer
28 matches
Mail list logo
