Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1559#issuecomment-177854554
@ChengXiangLi, just added you on Skype.
I'll write a mail to coordinate the time :-)
---
If your project is set up for it, you can reply to this email and have
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1559#issuecomment-177520097
Yes, good idea. My Skype name is `twalthr`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1559#issuecomment-177429493
Yes, i think we should do that, my Skype is chengxiang.li...@gmail.com.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user fhueske closed the pull request at:
https://github.com/apache/flink/pull/1559
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1559#issuecomment-176976611
@ChengXiangLi Thanks! I'll merge it to the `tableOnCalcite` branch.
@twalthr, @ChengXiangLi should we do a brief Skype call or chat beginning
next week to coordi
Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1559#issuecomment-176891835
Yes, @fhueske , i saw you rewrite the DataSetRelNodes on scala, i would
continue my work based on your PR.
---
If your project is set up for it, you can reply to t
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1559#issuecomment-176727999
+1 for merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1559#issuecomment-176693988
Updated the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1559#discussion_r51245496
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetRel.scala
---
@@ -0,0 +1,33 @@
+/*
+ * Lice
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1559#discussion_r51245443
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/JavaBatchTranslator.scala
---
@@ -41,21 +44,13 @@ class JavaBatchTransla
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1559#issuecomment-176676353
Except for the comments it looks very good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1559#discussion_r51241929
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetRel.scala
---
@@ -0,0 +1,33 @@
+/*
+ * Lice
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1559#discussion_r51241424
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetExchange.scala
---
@@ -0,0 +1,63 @@
+/*
+ *
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1559#discussion_r51241130
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/java/table/JavaBatchTranslator.scala
---
@@ -41,21 +44,13 @@ class JavaBatchTransla
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1559#issuecomment-176501262
@ChengXiangLi, @twalthr: Please review and give feedback.
@ChengXiangLi, this PR contains stubs for the translation rules which are
quite similar to the rules in
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1559
[FLINK-3225] Implemented optimization of Table API queries via Calcite
- added logical Flink nodes and translation rules
- added stubs for DataSet translation rules
- ported DataSetNodes to S
16 matches
Mail list logo
