Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1542#issuecomment-190650790
Hi @wenlonglwl,
you are right about this. We are thinking about how we can change the
system so that finite sources can emit a final Long.MAX_VALUE watermark when
t
Github user wenlonglwl commented on the pull request:
https://github.com/apache/flink/pull/1542#issuecomment-190586930
@aljoscha @StephanEwen This would not work for finite stream, data of
in-flight window would lost, when the stream finished. Can this clear window
operator changed to
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1542
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1542#issuecomment-176181849
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1542#discussion_r50720691
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/complex/ComplexIntegrationTest.java
---
@@ -214,6 +214,7 @@ public void complexIntegr
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1542#discussion_r50714080
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/complex/ComplexIntegrationTest.java
---
@@ -214,6 +214,7 @@ public void complexI
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1542#issuecomment-174547617
Looks good, with one inline question.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1542#discussion_r50709674
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/complex/ComplexIntegrationTest.java
---
@@ -214,6 +214,7 @@ public void compl
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1542#issuecomment-174439774
This seems to be straightforward :) Looks good :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1542
[FLINK-3178] Don't Emit In-Flight Windows When Closing Window Operator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink window-no
10 matches
Mail list logo
