Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1458#issuecomment-171972196
Makes sense.
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1458#issuecomment-171234571
OK, I've looked into it, and option 2) needs more checks in different parts
of the system in order to ensure that standalone mode correctly rejects random
ports and port ran
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1458#issuecomment-171043451
True, port ranges in standalone are a problem for the TaskManagers.
So our options are
1. As you implemented in this PR
2. Reuse the current confi
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1458#issuecomment-170937659
The port was not configured before (default 0).
I agree that now that you can configure it, it makes sense to use the
existing config key. ;)
I would like t
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1458#issuecomment-170561792
Hmm, to me it is confusing by itself that there are different parameters
for ports in HA mode and in standalone mode.
Taking a step back, I would expect this
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1458#issuecomment-170477745
All HA configuration is prefixed with `recovery`. If we rename it as you
suggest, I would like to move all HA related configuration to `jobmanager.ha`.
Any opinions?
---
I
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1458#issuecomment-168649715
Looks good, but the config key reads a bit confusing to me. Why prefix it
with `recovery`? It affects ports also in cases where the master never dies and
recovers. H
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1458
[FLINK-3172] Specify JobManager port in HA mode
- Adds support for job manager port configuration for standalone HA clusters
- Re-uses everthing introduced in #1416, but moves the `retry` method to
