Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-48940
Okay, let me explain:
I decided to remove the field, even though its public, and strictly
speaking a breaking API change. However, it was a mistake to mark the
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-08597
no my concern wasn't even remotely addressed.
The public static String CONFIG_KEY was removed in commit
5a7f4e3395bfb06da496584be88501c328f6ac1d, violating the interfa
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222185242
@zentol I think your concern was addressed here:
https://github.com/apache/flink/pull/2042/commits/c20efc6cda6ff705c72924213c90f618f7f40e51
Thanks all for the r
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2042
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2042#discussion_r64902741
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -82,6 +82,10 @@
private static final long DEFAULT_REST
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222139308
Thank you for the review.
Its very low overhead since the 1.0.0 jar's are cached in the local .m2
directory and the tool is doing the check really fast.
---
I
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222138890
+1 Looks good to me.
Only wondering, how much will it affect our build time? We might want to
run this in a dedicated profile.
---
If your project is set up for i
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222134657
The plugin runs with every mvn verify call.
For each maven module, it will download the last stable release (in this
case 1.0.0) and check it against the build
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222132940
Thanks for the pull request! Could you elaborate on how and where this will
be integrated with our CI or release process?
---
If your project is set up for it, you can repl
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2042
[FLINK-3129] Add tooling to ensure interface stability
This pull request adds a maven module for ensuring interface stability
(japicmp).
I needed to revert some of the changes since 1.0:
10 matches
Mail list logo
