Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-187716265
Have you thought about how the state backups would work if there was only
one previously running instance of redis available?
---
If your project is set up for it, you
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-187595766
@aljoscha @rmetzger What do you think? I like the idea to start up Redis
via `.travis.yml` for the tests.
---
If your project is set up for it, you can reply to this emai
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-187515384
Hello @mjsax , it is possible to use Travis for testing the redis. Travis
can start Redis during build. Please check out an example
[here](https://github.com/sbcd90/redis
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-187201289
I don't know enough about redis. Not sure how we can deal with the testing
situation.
---
If your project is set up for it, you can reply to this email and have your
r
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-187199830
I guess we can just move on here by assuming that Redis must be started
manually before it can be uses as state backend. We still need to figure out
how to test this: it i
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-182688977
@mjsax Would you open a new thread in dev-mailing-list for discussion on
redis-state-backend. I'm really interested in the topic. & would like to work
on it. I'm followin
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-182424633
@aljoscha @rmetzger Should we move this discussion to the mailing list?
@sbcd90 are you following dev-mailing list?
---
If your project is set up for it, you can reply to
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-182421979
Yes @mjsax you have the right ideas here. :smile: Those are the things that
need to be figured out.
---
If your project is set up for it, you can reply to this email a
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-182416665
I just put a few initial comments. Before you update this, we need to
figure out, how to deal with Redis server (ie, single server for each job,
shared server for multiple
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52468882
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java
---
@@ -0,0 +1,374 @@
+/
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52468737
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/RedisListState.java
---
@@ -0,0 +1,167 @@
+/**
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52468705
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/RedisListState.java
---
@@ -0,0 +1,167 @@
+/**
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52468562
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java
---
@@ -0,0 +1,374 @@
+/**
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52468108
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java
---
@@ -0,0 +1,374 @@
+/**
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52466186
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java
---
@@ -0,0 +1,374 @@
+/**
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52467132
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java
---
@@ -0,0 +1,374 @@
+/**
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52466745
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java
---
@@ -0,0 +1,374 @@
+/**
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52466304
--- Diff:
flink-contrib/flink-statebackend-redis/src/test/java/org/apache/flink/contrib/streaming/state/RedisStateBackendTest.java
---
@@ -0,0 +1,60 @@
+/*
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-182404055
We cannot have binary files in an release (ie, `redis-server-2.8.19` in
resource folder). Need to figure out to deal with this.
Of course, you need also to fix the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52465448
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/RedisValueState.java
---
@@ -0,0 +1,141 @@
+/**
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52465387
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/RedisListState.java
---
@@ -0,0 +1,167 @@
+/**
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52465412
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/RedisReducingState.java
---
@@ -0,0 +1,157 @@
+/**
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1617#discussion_r52465315
--- Diff:
flink-contrib/flink-statebackend-redis/src/main/java/org/apache/flink/contrib/streaming/state/AbstractRedisState.java
---
@@ -0,0 +1,374 @@
+/**
GitHub user sbcd90 opened a pull request:
https://github.com/apache/flink/pull/1617
[FLINK-3035] Redis as State Backend
@mjsax please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sbcd90/flink FLINK-3035
Alternatively y
24 matches
Mail list logo
