Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1422
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1422#issuecomment-164177222
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1422#issuecomment-163194318
All right, lets merge this then...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1422#issuecomment-163200275
Olrite. Great!
#1418 should also be meregable with this one IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1422#discussion_r47076123
--- Diff: flink-runtime-web/web-dashboard/app/partials/overview.jade ---
@@ -22,6 +22,12 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1422#discussion_r47073802
--- Diff: flink-runtime-web/web-dashboard/app/partials/overview.jade ---
@@ -22,6 +22,12 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main
.
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1422#issuecomment-162556656
@rmetzger this should be mergeable now. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1422#discussion_r46774718
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java
---
@@ -63,6 +67,10 @@ public Strin
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1422#discussion_r46773662
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java
---
@@ -63,6 +67,10 @@ public String hand
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1422#issuecomment-162333939
Tested the change on a cluster
---
If your project is
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1422#issuecomment-161914994
Addressed null commit ids. If the commit id is not available, only version
will be displayed.
---
If your project is set up for it, you can reply to this email a
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1422#issuecomment-161319181
+1 to what Stephan said. The commit id won't be available for releases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1422#issuecomment-160655656
Here also, should we show the commit only for snapshot versions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1422#issuecomment-160655246
Except for [one minor
comment](https://github.com/apache/flink/pull/1418#issuecomment-160652388), the
PR is good to merge.
---
If your project is set up for it, you c
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1422
[FLINK-3023][web-dashboard] Display version and commit information on
Overview Page.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sac
15 matches
Mail list logo
