Github user jaoki commented on the pull request:
https://github.com/apache/flink/pull/1355#issuecomment-156946307
Thank you for your input. @zentol ! Withdrawing PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jaoki closed the pull request at:
https://github.com/apache/flink/pull/1355
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1355#issuecomment-156869041
I'm not too fond of the new version either and feel like this code bit
doesn't really need more clarity, simply because it isn't a lot of code.
Using a counter a
Github user jaoki commented on the pull request:
https://github.com/apache/flink/pull/1355#issuecomment-156867821
@StephanEwen , thank you for your feedback. Looping with an int variable is
clearly wrong in Flink's use case, and I can change to long, but, I'd like to
hear more of this
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1355#issuecomment-156859098
Thanks for the interest in helping us maintain clear code.
I think actually that the original code was easier than the code with
counter checks. Further more
GitHub user jaoki opened a pull request:
https://github.com/apache/flink/pull/1355
[FLINK-3012] Refactor boilerplate code in DataSourceTask
Refactor repetitive and boilerplate code of while and if statements in
DataSourceTask
The previous if and else nest and to control the timi
