Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1371
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-158051108
Hey @twalthr, thanks!
I've created FLINK-3046 for the Either integration and I think FLINK-3042
is about custom type interfaces.
---
If your project is set up for it,
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-158048821
@vasia I can implement the TypeExtractor support.
@StephanEwen Custom type integration interfaces sound very good. I can open
an issue for that.
---
If your pr
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-158042526
Thanks. I'll squash the commits and merge later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-158027623
Looks good, +1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-158003742
Thanks! Updated. I'll open a JIRA for integrating it into the TypeExtractor.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45251503
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/Either.java ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software F
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45251332
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/Either.java ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software F
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45250671
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/EitherSerializer.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed to the Apac
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45250469
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/Either.java ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-157839083
Concerning the docs, we have often talked about "special types", which
would also include Scala's Option, Either, and Try. Would be great to add that
section.
---
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-157838535
Some small comments, otherwise +1 to merge.
Integration into the TypeExctractor can be a separate issue, in my opinion.
---
If your project is set up for it
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45249202
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/Either.java ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software F
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45248963
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/EitherSerializer.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed to th
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45248629
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/Either.java ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software F
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45248610
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/Either.java ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software F
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-157784970
Integrating it with the TypeExtractor means that the APIs recognize the
type and choose the type info properly.
I think @twalthr is probably the best to give
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-157767153
Thanks a lot for the review. I've updated the PR.
@gyfora @StephanEwen what do you mean by adding this to the type extractor?
What do I need to do?
Also, any commen
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-157716591
Looks pretty good, with a few comments inline!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45199245
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/EitherSerializer.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed to th
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45199091
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/EitherTypeInfo.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache S
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45199167
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/EitherTypeInfo.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache S
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45198942
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/Either.java ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software F
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45198871
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/Either.java ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software F
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45198787
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/Either.java ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software F
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45198671
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/Either.java ---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache Software F
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-157713609
+1 for including it into the type extractor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-157713501
The Java Optional comes only in Java 8, so we would need to implement this
in a reflective way. But I would like that a lot as well (replacement for
nullable fields)
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-157711434
Otherwise big :+1: for this, it is very useful, also we should add the
java Optional :)
---
If your project is set up for it, you can reply to this email and have your
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1371#issuecomment-157711193
I think we should add this to the TypeExtractor, otherwise it becomes very
clumsy.
I am using the same logic in my applications and defining the TypeInfo in
ret
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45180384
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/EitherSerializer.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed to t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1371#discussion_r45180256
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/EitherSerializer.java
---
@@ -0,0 +1,194 @@
+/*
+ * Licensed to t
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/1371
[FLINK-3002] Add Either type to the Java API
Implemented as discussed in the corresponding JIRA.
I haven't added this type to the docs yet. The data types section in the
programming guide con
33 matches
Mail list logo
