Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1926
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1926#issuecomment-215579092
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1926#issuecomment-215418083
Thanks for the fast update @dawidwys.
PR is good to merge :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1926#issuecomment-215254090
Thanks for the update @dawidwys. PR looks good except for a few minor
comments.
Can you also rebase to the current master? A recent commit updated some
code that you
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r61349569
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/SortITCase.scala
---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r61349399
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/package.scala
---
@@ -0,0 +1,62 @@
+/*
+ * License
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r61349443
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/DataSetSortRule.scala
---
@@ -0,0 +1,61 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r61349224
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/package.scala
---
@@ -0,0 +1,62 @@
+/*
+ * License
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r61348923
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/package.scala
---
@@ -0,0 +1,62 @@
+/*
+ * License
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r61348811
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r61348408
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/ordering.scala
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to t
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1926#issuecomment-214903475
Hi @dawidwys, thanks for the fast update. I'll have a look at the PR
tomorrow.
The JIRA for Table API outer joins is FLINK-2971. I'll assign it to you.
Thanks!
--
Github user dawidwys commented on the pull request:
https://github.com/apache/flink/pull/1926#issuecomment-214862766
I tried to address all your comments. Unfortunately I didn't notice lines
longer than 100 yesterday, sorry for that.
I started working on outer joins, but unfor
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60936652
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/SortITCase.scala
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed t
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1926#issuecomment-214388270
Thanks for the PR @dawidwys. I had a few comments. Please let me know if
you have any questions.
Regarding a follow task, we have several open issue to extend /
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60930292
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/SortITCase.scala
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60929903
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/SortITCase.scala
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60929272
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/SortITCase.scala
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60929017
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/SortITCase.scala
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60928727
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/SortITCase.scala
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60928598
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/SortITCase.scala
---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60928086
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60927218
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60926920
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60926405
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60926272
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala
---
@@ -0,0 +1,108 @@
+/*
+ * Li
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60926030
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -401,6 +400,52 @@ class Table(
new Table(relBuild
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60925922
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -401,6 +400,52 @@ class Table(
new Table(relBuild
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60924404
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/DataSetSortRule.scala
---
@@ -0,0 +1,51 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60923473
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/DataSetSortRule.scala
---
@@ -0,0 +1,51 @@
+/*
+ *
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60923428
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -401,6 +400,52 @@ class Table(
new Table(relBuild
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1926#discussion_r60923266
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/ordering.scala
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to t
Github user dawidwys commented on the pull request:
https://github.com/apache/flink/pull/1926#issuecomment-213575798
Always glad to help! In fact I would be happy for any suggestions what can
I work on further.
I changed the tests.
---
If your project is set up for it, you
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1926#issuecomment-213565509
Thanks for opening this PR @dawidwys!
I skimmed over the changes and it looks good. I will do a more detailed
review hopefully soon.
Thanks also for adding a
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/1926
[FLINK-2946] Add orderBy() to Table API
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take
35 matches
Mail list logo
