[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1281 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1281#issuecomment-150172859 Alright, will do. Thanks Fabian! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1281#issuecomment-150170995 Just merge to master and cherry pick the commit over to the release branch. No need to wait for more fixes. At some point, we build a new RC from the current release bra

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1281#issuecomment-150168427 Sure. Shall I do this after merging to master or shall we wait until we have more fixes for the RC? --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1281#issuecomment-150163859 As a bugfix, this can also go into the next 0.10 RC (i.e., cherry-pick to release branch). --- If your project is set up for it, you can reply to this email and have yo

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread vasia
Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1281#issuecomment-150163452 Thanks for reviewing @fhueske! I will add a comment to clarify what happens with the edge directions and merge this :) --- If your project is set up for it, you can reply

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1281#issuecomment-150162675 Good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1281#discussion_r42728398 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java --- @@ -129,24 +133,43 @@ public void postSuperstep

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/1281#discussion_r42726773 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java --- @@ -129,24 +133,43 @@ public void postSuperstep()

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1281#discussion_r42725042 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java --- @@ -129,24 +133,43 @@ public void postSuperstep

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1281#discussion_r42724967 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java --- @@ -129,24 +133,43 @@ public void postSuperstep

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-22 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1281#discussion_r42724980 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java --- @@ -129,24 +133,43 @@ public void postSuperstep

[GitHub] flink pull request: [FLINK-2887] [gelly] sendMessageToAllNeighbors...

2015-10-21 Thread vasia
GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/1281 [FLINK-2887] [gelly] sendMessageToAllNeighbors respects the EdgeDirection The method now checks whether the edge direction has been set and collects the correct msg. You can merge this pull request i