[GitHub] flink pull request: [FLINK-2827] Closing FileInputStream in finall...

2015-10-21 Thread ssaumitra
Github user ssaumitra commented on the pull request: https://github.com/apache/flink/pull/1276#issuecomment-149862453 I just observed that Flink has already dropped Java 6 support. try with resources is the best possible approach then. I will amend my commit. --- If your project is s

[GitHub] flink pull request: [FLINK-2827] Closing FileInputStream in finall...

2015-10-21 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1276#issuecomment-149861772 +1 We're on Java 7, which allows to implicitly close resources in a try statement: --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] flink pull request: [FLINK-2827] Closing FileInputStream in finall...

2015-10-21 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1276#issuecomment-149856389 How about using a "try with resources" statement? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] flink pull request: [FLINK-2827] Closing FileInputStream in finall...

2015-10-20 Thread ssaumitra
Github user ssaumitra commented on a diff in the pull request: https://github.com/apache/flink/pull/1276#discussion_r42527314 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-twitter/src/main/java/org/apache/flink/streaming/connectors/twitter/TwitterSo

[GitHub] flink pull request: [FLINK-2827] Closing FileInputStream in finall...

2015-10-20 Thread ssaumitra
GitHub user ssaumitra opened a pull request: https://github.com/apache/flink/pull/1276 [FLINK-2827] Closing FileInputStream in finally block to avoid unused open stream. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ssaumitra