Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1202
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-146991947
Oh I forgot. I still want to test it on Yarn.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-146991673
Great ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-146991497
Have fixed a possible race condition in `JobManagerRetriever` and rebased
on the latest master. If Travis gives green light, I'll merge it.
---
If your project is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-146737613
Are there any blockers to this PR. Otherwise, I'd like to have it merged
rather soon.
---
If your project is set up for it, you can reply to this email and have your
r
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-145885023
It's not superficial at all. It's cleaner, because the retriever is
independent of the redirect logic then.
I've decided against it though in order to keep the handl
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-145878794
I've added some more comments. Ping me if it's too superficial.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1202#discussion_r41272418
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -150,97 +148,97 @@ else if (flinkRoot != nul
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1202#discussion_r41272295
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java
---
@@ -44,27 +47,40 @@
public class Runti
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1202#discussion_r41272107
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/JobManagerArchiveRetriever.java
---
@@ -47,51 +60,160 @@
private f
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-145868099
OK. I've addressed your comments in the last two commits. Thanks again!
- The associated local leader gateway is only resolved once and getGateway
will only return t
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-145786422
Yes, good point. I will do this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-145781149
What you can actually do to resolve the issue with the `RequestHandler` is
to statically assign them the local JM's address instead of providing a
`JobManagerArchiv
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1202#discussion_r41169783
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/JobManagerArchiveRetriever.java
---
@@ -70,28 +104,68 @@ public ActorGateway getArc
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1202#discussion_r41169911
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1773,8 +1812,7 @@ object JobManager {
.asSubclas
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-145598003
The PR looks good. I think we cannot do much about it being a temporary
workaround for the limitation that our `ExecutionGraph` is not serializable.
Once we have th
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1202#discussion_r41167164
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/JobManagerArchiveRetriever.java
---
@@ -70,28 +104,68 @@ public ActorGatew
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1202#discussion_r41167117
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/JobManagerArchiveRetriever.java
---
@@ -70,28 +104,68 @@ public ActorGatew
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1202#discussion_r41164549
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1761,11 +1803,8 @@ object JobManager {
* @pa
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1202#discussion_r41164567
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1773,8 +1812,7 @@ object JobManager {
.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1202#discussion_r41164028
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -129,6 +129,13 @@ class JobManager(
var leader
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1202#discussion_r41163935
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -129,6 +129,13 @@ class JobManager(
var leader
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-144752438
I already opened the PR. Will review it asap.
On Thu, Oct 1, 2015 at 4:38 PM, Robert Metzger
wrote:
> No, I didn't try it.
>
> â
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-144747629
No, I didn't try it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-144746710
I would squash all commits and add the JIRA. Have you tried it out?
I would like to hear @tillrohrmann's take on this "abstraction" breaking
behaviour before merging
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1202#issuecomment-144745094
+1 The change looks good to merge. (maybe we should add the JIRA id when
merging)
---
If your project is set up for it, you can reply to this email and have your
reply
26 matches
Mail list logo
