Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1176#issuecomment-143187594
Looks good. Thanks for the contribution @rerngvit!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1176#issuecomment-142910324
Looks good to merge. I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rerngvit commented on the pull request:
https://github.com/apache/flink/pull/1176#issuecomment-142900768
@chiwanpark Thanks for reviewing this issue. I modified the pull request
according to your comments.
---
If your project is set up for it, you can reply to this email
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1176#issuecomment-142895387
Hi @rerngvit, I have tested your pull request.
Because `setup_quickstart.html` contains "setup" keyword in url, there are
two active menus (Quickstart, Setup)
Github user rerngvit commented on the pull request:
https://github.com/apache/flink/pull/1176#issuecomment-142868010
@chiwanpark Thanks for reviewing this issue. I modified the pull request
according to your comments. Please have a look.
---
If your project is set up for it, you can
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1176#issuecomment-142863133
Hi @rerngvit, Thanks for sending pull request. But your pull request has
some problems.
First, `{{ quickstart }}` is not defined in your changes. As you can s
GitHub user rerngvit opened a pull request:
https://github.com/apache/flink/pull/1176
[FLINK-2751] [Documentation] Add quickstart menu to the navigation bar
Add quickstart menu to the navigation bar for Flink documentation
You can merge this pull request into a Git repository by run
