Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r44281079
--- Diff: flink-runtime-web/web-dashboard/bower.json ---
@@ -23,7 +23,8 @@
"dagre-d3": "~0.4.10",
"font-awesome": "~4.3.0",
"
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r44280702
--- Diff: flink-runtime-web/web-dashboard/bower.json ---
@@ -23,7 +23,8 @@
"dagre-d3": "~0.4.10",
"font-awesome": "~4.3.0",
"moment-dura
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r44278942
--- Diff: flink-runtime-web/web-dashboard/bower.json ---
@@ -23,7 +23,8 @@
"dagre-d3": "~0.4.10",
"font-awesome": "~4.3.0",
"
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r44277088
--- Diff: flink-runtime-web/web-dashboard/bower.json ---
@@ -23,7 +23,8 @@
"dagre-d3": "~0.4.10",
"font-awesome": "~4.3.0",
"mom
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r44276336
--- Diff: flink-runtime-web/web-dashboard/bower.json ---
@@ -23,7 +23,8 @@
"dagre-d3": "~0.4.10",
"font-awesome": "~4.3.0",
"
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r44274673
--- Diff: flink-runtime-web/web-dashboard/bower.json ---
@@ -23,7 +23,8 @@
"dagre-d3": "~0.4.10",
"font-awesome": "~4.3.0",
"moment-dura
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146922016
Merging this after a final test...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146915677
Build passes successfully. Looking forward to seeing this merged. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146871440
Looks good to merge now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146841207
@mxm I modified the code to remove null values. It should be mergeable now.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r41619556
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -536,6 +536,11 @@ class JobManager(
)
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r41618643
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagersHandler.java
---
@@ -54,10 +58,22 @@ public String
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146832468
The initial look is a bit weird, I agree. There is a potential fix, by
fetching the usage upto the point when someone clicks on the `metrics` tab,
however, that c
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146831304
Tried out your changes it everything worked without quirks. The initial
look is a bit odd when the charts haven't loaded yet but this is nothing that
should prevent us from
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r41617865
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagersHandler.java
---
@@ -54,10 +58,22 @@ public String handleReque
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r41617830
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -536,6 +536,11 @@ class JobManager(
)
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r41615077
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagersHandler.java
---
@@ -39,6 +42,7 @@
pr
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1236#discussion_r41612793
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagersHandler.java
---
@@ -39,6 +42,7 @@
private final
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146802623
The screenshots look great. I'll check out your work now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146440113
I think I broke something while addressing Piotr's concerns. Will debug and
push the fixed version again.
---
If your project is set up for it, you can reply to
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146439447
@aljoscha FYI I've added a new Job Manager message which returns the
metrics only for one particular instance to minimize unnecessary traffic for a
single taskman
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146439104
@iampeter , thanks for the review. I've addressed all your comments.
I removed the `No such task ...` thing entirely. It doesn't have a use case
anyways. We do
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146438040
Thanks for the review @iampeter :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user iampeter commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146333800
@sachingoel0101 @aljoscha looks great, but I would make the following
changes if possible:
1. Move the 'livechart' directive to a separate file -
`taskmanager.
Github user iampeter commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146320512
@aljoscha ok will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146200566
@iampeter, could you please have a look so that we can quickly merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146193727
Thanks. :)
Although there's not much to review here. :') It's mostly a rearrangement
of existing content, with a major addition in `taskmanager.ctrl.coffee`
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146193617
Really cool graphs Sachin :-) Looking forward monitoring my Flink jobs with
these graphs.
On Wed, Oct 7, 2015 at 3:10 PM, Aljoscha Krettek
wrote:
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1236#issuecomment-146191633
Wow, the screenshots look super nice. :smile:
Someone with knowledge about the new web fronted should probably review the
code, though.
---
If your project i
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1236
[FLINK-2730][web-dashboard] Adds cpu and memory usage graphs.
Screenshots:
