Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1266#issuecomment-157702242
Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1266#issuecomment-157675819
I think it's good :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1266#issuecomment-157662815
any other comments? I'll merge it other wise later on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1266#issuecomment-155764846
@fhueske I've addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1266#discussion_r1239
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -18,32 +18,97 @@
package org.apache.flink.api.java.io;
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1266#issuecomment-155515305
I agree with @aljoscha and you on the `readRecord()` code. It would be nice
to have the common parts of `readRecord()` in the `CsvInputFormat` and specific
`fillRecord`
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1266#discussion_r44439588
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -18,32 +18,97 @@
package org.apache.flink.api.java.io;
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1266#discussion_r44438028
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/PojoCsvInputFormat.java
---
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1266#discussion_r44435810
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -18,32 +18,97 @@
package org.apache.flink.api.java.io;
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1266#discussion_r44435787
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -18,32 +18,97 @@
package org.apache.flink.api.java.io;
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1266#discussion_r44434469
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -18,32 +18,97 @@
package org.apache.flink.api.java.io;
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1266#discussion_r44434150
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -18,32 +18,97 @@
package org.apache.flink.api.java.io;
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1266#issuecomment-153024659
I think you can go ahead and merge it then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1266#issuecomment-152592464
yes, the user facing API is unchanged; it's only a problem for those that
uses the CsvInputFormat directly for a createInput() call or whatever.
---
If your project is s
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1266#issuecomment-152585852
Could, yes, but I'm fine with both, it is already cleaner than what we had
before.
The user facing API is not changed, right? So I think this is good to merge.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1266#issuecomment-152584371
We could move the differing lines (Csv:L114 Pojo:L218->L225) into separate
methods that is called from a generic readRecord() method. something like
fillRecord(OUT reuse,
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1266#issuecomment-152544715
Looks good to me. Is there maybe a way to also make `readRecord()` common
to tuples and POJOs, because there we duplicate all the code and only the call
that creates th
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1266
[FLINK-2692] Untangle CsvInputFormat
This PR splits the CsvInputFormat into a Tuple and POJO Version. To this
end, The (Common)CsvInputFormat classes were merged, and the type specific
portions refa
19 matches
Mail list logo
