[GitHub] flink pull request: [FLINK-2668] Chained Projections are no longer...

2015-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2668] Chained Projections are no longer...

2015-10-22 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1279#issuecomment-150318859 Will merge this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] flink pull request: [FLINK-2668] Chained Projections are no longer...

2015-10-22 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1279#issuecomment-150213016 Go ahead --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] flink pull request: [FLINK-2668] Chained Projections are no longer...

2015-10-22 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1279#issuecomment-150211310 Thanks for the update, looks good. I will merge this into `master` and `release-0.10` unless somebody objects. --- If your project is set up for it, you can reply t

[GitHub] flink pull request: [FLINK-2668] Chained Projections are no longer...

2015-10-22 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1279#issuecomment-150177113 @fhueske I've made the changes you suggested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] flink pull request: [FLINK-2668] Chained Projections are no longer...

2015-10-22 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1279#issuecomment-150163567 Regarding the PR itself: The `ProjectOperator` class can be cleaned up a bit more. By removing the two methods, the member variable `proj` becomes unused and the con

[GitHub] flink pull request: [FLINK-2668] Chained Projections are no longer...

2015-10-21 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1279#issuecomment-149962442 I would break the API since the old behavior can be confusing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2668] Chained Projections are no longer...

2015-10-21 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1279#issuecomment-149952138 Do we agree to break the API for this change? And if so, should we add this change before or after the 0.10 release? --- If your project is set up for it, you can r

[GitHub] flink pull request: [FLINK-2668] Chained Projections are no longer...

2015-10-21 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/1279 [FLINK-2668] Chained Projections are no longer appended Chained project() calls (like project(0).project(1)) are no longer merged into a single projection, but instead applied separately. This means