Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1112#issuecomment-139189765
+1, will merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1112#issuecomment-139127959
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1112#issuecomment-138988378
Looks good, modulo the one inline comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1112#discussion_r39073704
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
@@ -922,19 +922,18 @@ public boolean updateState(Ta
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1112#issuecomment-138976625
Thanks for the review. I've since extended this pull request. Upon failure
to deserialize the final task accumulator results, we now fail `Executions` and
forward the Except
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1112#issuecomment-138950226
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1112
[FLINK-2645][jobmanager] forward exceptions when merging final accumlator
results
- fix forwarding
- add test case
You can merge this pull request into a Git repository by running:
$ git pull
