[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-26 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-151092573 hi @rmetzger , I believe I find the reason why my test failed. A test will fail if we don’t specify “-t” argument(_which is an optional argument_) in the c

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-25 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-150928188 Sorry for the failed tests, I'll fix them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-25 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-150919886 Hi rmetzger, I have updated this PR. I generated a flink-conf.yaml in a directory, which I then used as the configuration directory for the test. --- If your

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-09 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-147009266 That's indeed a good question. I don't have much time currently, but I'm trying to answer you within the next few days. --- If your project is set up for it, you can r

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-07 Thread willmiao
Github user willmiao commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-146371570 @rmetzger : I'm sorry for the late reply, I have been on vacation last three weeks. I failed to find a nice way to "generate a flink-conf.yaml just for the test", c

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-10-01 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-144765643 @willmiao: What is the status of this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-09-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-141019208 For others who follow this PR, there was already some discussion on this change here: https://github.com/apache/flink/pull/1107 --- If your project is set up for it, y

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-09-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1121#discussion_r39725238 --- Diff: flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java --- @@ -111,6 +111,20 @@ public void testClientStartup() {

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-09-17 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1121#discussion_r39725184 --- Diff: flink-dist/src/main/resources/flink-conf.yaml --- @@ -130,6 +130,15 @@ state.backend: jobmanager #

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-09-17 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1121#issuecomment-141016403 Sorry for the late response, I didn't see this new pull request. The failed test is okay. The test is known for being unstable. --- If your project is set up f

[GitHub] flink pull request: [FLINK-2591] Add configuration parameter for d...

2015-09-11 Thread willmiao
GitHub user willmiao opened a pull request: https://github.com/apache/flink/pull/1121 [FLINK-2591] Add configuration parameter for default number of yarn containers You can merge this pull request into a Git repository by running: $ git pull https://github.com/willmiao/flink