Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1183#issuecomment-143725226
Thank you for the review @StephanEwen! I'll address your comments and merge
later.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1183#discussion_r40544282
--- Diff:
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/utils/Tuple2ToVertexMap.scala
---
@@ -0,0 +1,31 @@
+/*
+ * Licens
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1183#issuecomment-143714240
Looks good to me!
One style comment: I think that `collect()` should be written with
parenthesis. In Scala, you use parenthesis if the methods are not purely
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1183#discussion_r40540447
--- Diff:
flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/utils/Tuple2ToVertexMap.scala
---
@@ -0,0 +1,31 @@
+/*
+ *
