[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1211#issuecomment-146258426 I believe they're all fixed now! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1211#issuecomment-146250070 sure, looks good mostly. Found a few lines that need to be changed though. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1211#discussion_r41411193 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/example/SingleSourceShortestPaths.scala --- @@ -0,0 +1,170 @@ +/*

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1211#discussion_r41411055 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/example/SingleSourceShortestPaths.scala --- @@ -0,0 +1,170 @@ +/*

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1211#discussion_r41410709 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/example/GSASingleSourceShortestPaths.scala --- @@ -0,0 +1,156 @@ +/

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1211#discussion_r41410532 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/example/GSASingleSourceShortestPaths.scala --- @@ -0,0 +1,156 @@ +/

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1211#discussion_r41410322 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/example/ConnectedComponents.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1211#issuecomment-146245763 @fhueske do you want to take another look and see if anything looks off now? Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user vasia commented on the pull request: https://github.com/apache/flink/pull/1211#issuecomment-146237334 The formatting in the rest of the gelly-scala code looks OK. This one got messed up as I copies some methods from the Java examples. I'll fix the formatting and merge this

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1211#issuecomment-146200483 The examples look good. But the indention of the Scala code is quite different from the remaining Flink Scala code. Is the remaining Gelly Scala code formatted in th

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1211#discussion_r41389613 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/example/ConnectedComponents.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1211#discussion_r41389493 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/example/ConnectedComponents.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1211#discussion_r41389386 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/example/ConnectedComponents.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1211#discussion_r41388362 --- Diff: flink-staging/flink-gelly-scala/src/main/scala/org/apache/flink/graph/scala/example/ConnectedComponents.scala --- @@ -0,0 +1,121 @@ +/* + *

[GitHub] flink pull request: [FLINK-2561] Adds gelly-scala examples

GitHub user vasia opened a pull request: https://github.com/apache/flink/pull/1211 [FLINK-2561] Adds gelly-scala examples This PR addresses the remaining issues of FLINK-2561. It adds 3 gelly-scala examples: one vertex-centric sssp, one gsa-sssp and one showing how to use librar