Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1067
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1067#issuecomment-136667661
Looks good, I'll merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1067#issuecomment-136243437
Nice job, @greghogan , you just pointed out the root cause and the
solution. I add the logic to skip latest buckets as @StephanEwen suggested, and
add related unit
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1067#issuecomment-135983916
Ah, that makes perfect sense. The last memory segment is not fully used
(only until the hash index has initialized enough buckets). The bloom filter
initialization l
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1067#issuecomment-135885866
I am currently running release-0.10.0-milestone-1.
Debugging with Eclipse and looking at MutableHashTable.initTable,
numBuckets is computed as 16086. There are
Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1067#issuecomment-135612599
Thanks for the remind, @zentol and @StephanEwen , I should be too hurry to
open this PR. I tried to fix the exception in bloom filter in this PR and
verify other po
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1067#issuecomment-135354418
@ChengXiangLi Do you know what caused the problem initially? I was puzzled,
because the count in the bucket should never be negative, and a zero sized
bucket should
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1067#issuecomment-135342976
Have you verified that returning at that position does not cause other
issues? This is essentially just swallowing the thrown exception, hoping
nothing else goes wrong.
GitHub user ChengXiangLi opened a pull request:
https://github.com/apache/flink/pull/1067
[FLINK-2545] add bucket member count verification while build bloom filter
Bug fix, see detail error message at
[FLINK-2545](https://issues.apache.org/jira/browse/FLINK-2545).
You can merge th
