Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-157826454
Agreed.
I also would like to cleanup the several getter functions for these fields.
We can just add a `getTaskInfo` in the `TDD`, `Task` and `Environment`. Th
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-157824468
Yes, a TaskInfo is a good idea.
It can be handed also to the `RuntimeEnvironment` (from there to the
`RuntimeContext`), and is created once in the Task const
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-157818292
Yes. That's why I closed it. :')
I'm thinking of having a construct named `TaskInfo`, which contains
information like name, index, parallel tasks, attempt numb
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-157753581
Sorry for dropping this. The feature is still interesting. I have the
feeling it can probably be implemented a bit simpler...
---
If your project is set up for it,
Github user sachingoel0101 closed the pull request at:
https://github.com/apache/flink/pull/1026
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-155921293
Closing this for now. Needs reworking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-141653638
Unrelated failure on travis. Filed a jira [2711]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-141461094
Is it possible to get this in soon? I need access to the task manager
configuration for something I'm working on. @StephanEwen
---
If your project is set up for
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-138503010
Sure. No worries. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-138490882
Yeah, I'd like to add this once I find the time. Bit overloaded right now,
please bear with us for a bit...
---
If your project is set up for it, you can reply to t
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-138404446
Will there be any further review of this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-137116109
Travis Passes successfully.
https://travis-ci.org/apache/flink/builds/78368635
---
If your project is set up for it, you can reply to this email and have your
re
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-137009547
Rebased to the current master. This should be mergeable now. Travis fails
on unrelated kafka and flink-fs-tests. Just re-triggered another build.
@StephanEwen
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-132453057
@StephanEwen , I have fixed the styling issues as much as I could find out.
Thanks for your patience. :)
---
If your project is set up for it, you can reply
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-132449408
Sure thing. I'll fix it. IntelliJ re-formats used to take care of such
things, but I've stopped using it recently as it was messing up scala code.
---
If your pr
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-132322001
Sorry to be picky again, but it would be good to harmonize the code style a
bit - make it more consistent with the remaining code.
What struck me in particul
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-132199820
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1026#discussion_r37294536
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/TaskRuntimeInfo.java ---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-132198739
Rebased to the latest master. Can be merged now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-131853677
I have implemented a `TaskRuntimeInfo` which holds descriptive information
about the task, such as name, index, parallelism, etc. Also renamed the
`TaskManagerRun
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-131771732
Yes, let's have a `TaskRuntimeInfo` and a `TaskManagerContext`. Both are
available in the `RuntimeEnvironment` and passed to the `RuntimeContext`.
The `TaskR
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-131768999
Yes. Minimizing the arguments being passed to `RuntimeContext` was the
motivation. I thought about putting every task specific field into the TaskInfo
object but
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-131767636
Looks mostly good.
The `TaskRuntimeInfo` is now a bit strange. It contains some runtime info
for tasks (attempt number) but not all (subtasks, etc). The atte
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1026#discussion_r37173958
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java
---
@@ -120,7 +125,7 @@ public TaskDeploymentD
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1026#discussion_r37173822
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java
---
@@ -93,6 +93,15 @@ public int getInde
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1026#discussion_r37173778
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java
---
@@ -120,7 +125,7 @@ public TaskDeploymentDesc
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1026#discussion_r37173574
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java
---
@@ -93,6 +93,15 @@ public int getIndexOf
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-131660699
Since #970 is in, this can be merged now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/1026
[FLINK-2488][FLINK-2496] Expose Task Manager configuration and Task attempt
number to Runtime context
This PR fixes these issues:
1. [FLINK-2496]Expose Task Manager configuration to Runti
29 matches
Mail list logo
