Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1031
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1031#issuecomment-136780181
Okay. Great. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1031#issuecomment-136669559
I think this looks good. Will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1031#issuecomment-136349300
@StephanEwen, this should be mergeable now.
I've separated the Gelly change as a second commit.
---
If your project is set up for it, you can reply to this em
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1031#issuecomment-134265716
Yes, that's perfectly doable. I actually did that initially. The only
reason to add it to the `ExecutionEnvironment` was to remove that little bit of
code duplica
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1031#issuecomment-134227222
I do not quite understand the idea behind this pull request. It adds a
public `setAsShared()` method to the core `ExecutionEnvironment` which is only
relevant for te
