Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/941
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-139186364
I will rebase and merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-138956199
Do this PR need modification? It seems good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125192692
I guess the "s" in the name is the giveaway...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125191075
sbt can't do that.
We are lucky here because the `maven-shade-plugin` is generating a
dependency-reduced pom with the effective settings.
(Take a look in your
`/
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125189988
If sbt can resolve profile-based dependencies this should be OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125185305
Hi, pom.xml file of flink-scala module has also profile based dependency
setting. Is it okay without modification?
---
If your project is set up for it, you can reply
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125182364
Then it should be good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125181480
I don't think that I'm removing the activation of the `scala-2.11` profile.
If the `scala-2.11` property is set, the default value of the property will
be overwritten
Github user aalexandrov commented on the pull request:
https://github.com/apache/flink/pull/941#issuecomment-125180542
Is the removal of the property-based activation (`-Dscala-2.11`) also
intentional? I think this might be used in the travis.yml.
---
If your project is set up for it
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/941
[FLINK-2408] Define all maven properties outside build profiles
See JIRA issue for details.
@aalexandrov, can you take a look at this?
You can merge this pull request into a Git repository
11 matches
Mail list logo
