Github user sachingoel0101 closed the pull request at:
https://github.com/apache/flink/pull/945
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-160431771
Un-assigning myself from the issue for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r39268191
--- Diff: flink-core/src/main/java/org/apache/flink/util/VersionUtils.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundati
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r39266023
--- Diff: flink-core/src/main/java/org/apache/flink/util/VersionUtils.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r39265532
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobSubmitTest.java
---
@@ -192,4 +193,78 @@ public void initializeOnMaster(ClassLoad
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-136356151
Rebased to the current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-135372659
@tillrohrmann , I have modified the way version information is passed to
the Job Manager. It is now through the Configuration object passed.
Further, rolled bac
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r38000188
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -524,13 +534,24 @@ class JobManager(
* @param
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r3882
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -547,7 +552,7 @@ class TaskManager(
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-135045372
Hi @tillrohrmann , thanks for the review. You're right. `getClass...` is
not the right way to go. I had decided to just use this for the moment. We can
certainly h
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37989581
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobSubmitTest.java
---
@@ -170,4 +170,43 @@ public void initializeOnMaster(Cl
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37989473
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -547,7 +552,7 @@ class TaskManager(
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37989277
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -54,8 +54,12 @@
/** Stores the concre
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37989214
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -54,8 +54,12 @@
/** Stores the concre
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37988692
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -524,13 +534,24 @@ class JobManager(
* @para
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37988579
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -166,7 +169,8 @@ class JobManager(
taskMa
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-135026427
I had some comments concerning the implementation. I think as a first step
we should not check whether the JM and TM have the same versions because in
nearly all cas
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37981943
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -54,8 +54,12 @@
/** Stores the concrete
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37981839
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -205,7 +205,7 @@ public static void submitJobDetached(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37978132
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -54,8 +54,12 @@
/** Stores the concrete
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37978039
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobSubmitTest.java
---
@@ -170,4 +170,43 @@ public void initializeOnMaster(Clas
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37977961
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobSubmitTest.java
---
@@ -170,4 +170,43 @@ public void initializeOnMaster(Clas
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37977899
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobSubmitTest.java
---
@@ -170,4 +170,43 @@ public void initializeOnMaster(Clas
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37977813
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -547,7 +552,7 @@ class TaskManager(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37977713
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -524,13 +534,24 @@ class JobManager(
* @param
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37977616
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -184,26 +188,32 @@ class JobManager(
}
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37977495
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -166,7 +169,8 @@ class JobManager(
taskMana
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37977399
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -121,11 +121,14 @@ class JobManager(
over
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-130241985
I've already added a version check between `JobClient` and `JobManager`.
Will there be any further review of this?
---
If your project is set up for it, you can r
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-125991194
1. Added version checks between JobClient and JobManager.
2. Versions are accessed from the Configuration class now, since flink-core
gets built first and vers
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-125886476
Using `getClass().getPackage().getImplementationVersion()` would be a
decent first approach then, I guess. The critical part seems to be the
Client-to-JobManager comm
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-125734265
I had decided to work with my own understanding of what version means since
nobody replied to the JIRA comment.
getClass.getPackage.getImplementationVersion wou
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-125732043
I think we need to decide first what we actually mean by version and what
is supposed to match what.
What is actually the value
`getClass().getPackage().getI
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/945
[FLINK-2399] Version checks for Job Manager and Task Manager
[Reopening #944. The travis build failed somehow. ]
Both Job Manager and Task Manager now communicate their respective version
Github user sachingoel0101 closed the pull request at:
https://github.com/apache/flink/pull/944
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/944#issuecomment-125216770
Adding these checks however already make sure the older task manager or job
manager will be able to register with the new ones because the message objects
have cha
GitHub user sachingoel0101 opened a pull request:
https://github.com/apache/flink/pull/944
[FLINK-2399] Version checks for Job Manager and Task Manager
Both Job Manager and Task Manager now communicate their respective version
IDs to each other as part of registration messages.
37 matches
Mail list logo
