Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1066
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-140212838
Thanks for the update!
Will merge this PR tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user akunft commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-139622654
* rebased
* replaced collection output with ```collect()``` in
RemoteEnvironmentITCase and ExecutionEnvironmentITCase
* added ```createRemoteEnvironment``` method
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-139494208
LGTM modulo one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1066#discussion_r39253434
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/RemoteEnvironmentITCase.java
---
@@ -0,0 +1,164 @@
+/*
+ * Licensed t
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-139279212
LGTM, @tillrohrmann do you want to have another look as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1066#discussion_r38629325
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/RemoteEnvironmentITCase.java
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed t
Github user akunft commented on a diff in the pull request:
https://github.com/apache/flink/pull/1066#discussion_r38556752
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/RemoteEnvironmentITCase.java
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the
Github user akunft commented on a diff in the pull request:
https://github.com/apache/flink/pull/1066#discussion_r38556479
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/RemoteEnvironmentITCase.java
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the
Github user akunft commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-137165900
Yes, I didn't enforce that the config parameter is not used, but the
setParallelism overrides it.
I let it like this, as it is more confusing to the user if all this i
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1066#discussion_r38555428
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/RemoteEnvironmentITCase.java
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed t
Github user akunft commented on a diff in the pull request:
https://github.com/apache/flink/pull/1066#discussion_r38554964
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/RemoteEnvironmentITCase.java
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-136969071
From your last comment I conclude that you only wanted to allow akka
specific features to be set with the configuration. However, I couldn't find
how you check this
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1066#discussion_r38506469
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/RemoteEnvironmentITCase.java
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1066#discussion_r38506169
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/RemoteEnvironmentITCase.java
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed t
Github user akunft commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-136829682
Added tests + behavior described above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user akunft commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-135830165
After thinking about it, I would change the behavior so that the config is
only for defining akka specific settings. The default parallelism of the
operators can be set v
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-135448224
@uce, I think this should be addressed either in #1016 or in a separate PR
once #1016 is merged.
---
If your project is set up for it, you can reply to this email
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-135372450
Thanks for the PR. I agree with Till.
@tillrohrmann, regarding #1016: what would be the way to use the
RemoteEnvironment with an HA cluster? This will already work w
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1066#issuecomment-135348048
Very good contribution. Thanks @akunft. The only thing would be to add a
test which verifies that the configuration is actually used for starting the
`JobClientActo
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1066#discussion_r38074069
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -1105,6 +1105,27 @@ public static ExecutionEnvironment
cre
GitHub user akunft opened a pull request:
https://github.com/apache/flink/pull/1066
[FLINK-2373] Add configuration parameter to createRemoteEnvironment method
Adds an overloaded ExecutionEnvironment.createRemoteEnvironment method to
provide a custom configuration for the job client.
22 matches
Mail list logo
