[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/884 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-13 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/884#issuecomment-120940126 @gyfora merged this already! PR is not closed because Github is behind aft-git! --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-13 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/884#issuecomment-120940089 Ah, just saw it is already merged. Github is out of sync... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-13 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/884#issuecomment-120939188 +1 good to go, with the followup issues being addresses in separate issues. Merging this... --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-09 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/884#issuecomment-119943363 I just created two JIRAs: - SLF4J: https://issues.apache.org/jira/browse/FLINK-2337 - JobExecutionException: https://issues.apache.org/jira/browse/FLINK-2338

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-09 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/884#issuecomment-119870990 Let's make it a separate issue. If there is a followup on these two issues, we can merge this, in my opinion. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-08 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/884#issuecomment-119715279 1) Agreed. Should I add this to this PR or open a JIRA and a new PR? 2) This is a know issues that will be resolved with the new STOP signal. --- If your project is set

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-08 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/884#issuecomment-119710264 I just tested the storm compatibility code, and stumbled across the following issues in the logs: 1) Multiple SLF4J bindings. If Storm brings its own one, we

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-08 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/884#discussion_r3410 --- Diff: docs/apis/storm_compatibility.md --- @@ -0,0 +1,155 @@ +--- +title: "Storm Compatibility" +is_beta: true +--- + + +[Flink st

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-08 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/884#issuecomment-119596298 +1 to merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-08 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/884#discussion_r34152734 --- Diff: docs/apis/storm_compatibility.md --- @@ -0,0 +1,155 @@ +--- +title: "Storm Compatibility" +is_beta: true +--- + + +[Flink

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-03 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/884#issuecomment-118287253 FYI: this PR is related to #878 -> if #878 is merged before, this PR needs an update. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-2305] Add documenation about Storm comp...

2015-07-02 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/flink/pull/884 [FLINK-2305] Add documenation about Storm compatibility layer additional improvements - added RawOutputFormatter - bug fix in SimpleOutputFormatter - enable default output formatter for Stor