Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111741260
Thanks, nice work. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/831
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user Shiti commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111723371
@aljoscha I have made the suggested changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111717366
I had some more remarks, sorry for being so picky. :sweat_smile:
Other than that, I think the change looks really good now!
---
If your project is set up for i
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/831#discussion_r32371128
--- Diff:
flink-staging/flink-table/src/test/scala/org/apache/flink/api/table/typeinfo/RowSerializerTest.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/831#discussion_r32371124
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RowSerializer.scala
---
@@ -102,20 +119,39 @@ class RowSerializer(fiel
Github user Shiti commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111709239
@aljoscha I have updated the RowSerializerTest to use SerializerTestBase
and reverted to using while loops in RowSerializer
---
If your project is set up for it, you can r
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111701489
The changes look good except for comments I had about the loops.
For the tests, did you try doing it as in TraversableSerializerTest.scala.
Here, we override dee
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/831#discussion_r32369781
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RowSerializer.scala
---
@@ -74,11 +79,16 @@ class RowSerializer(fieldS
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/831#discussion_r32369782
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/RowSerializer.scala
---
@@ -89,11 +99,16 @@ class RowSerializer(fieldS
Github user Shiti commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111682105
@hsaputra I have updated the description
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/831#issuecomment-111627080
HI @Shiti , thanks for the patch.
Could you add in the PR description on how the fix is done and what changes
made to fix it.
This will help reviewers follow you
GitHub user Shiti opened a pull request:
https://github.com/apache/flink/pull/831
[FLINK-2203] handling null values for RowSerializer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Shiti/flink FLINK-2203
Alternatively you can r
13 matches
Mail list logo
