Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146891720
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146578397
@StephanEwen I think so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146578211
Ah, I see. Then the change looks good, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146465380
If we need to parallelize tests run by scalatest, the test cases should
extend
[ParallelTestExecution](http://doc.scalatest.org/2.2.4/index.html#org.scalatest.Paralle
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146449913
FlinkML uses scalatest to run its tests. Scalatest didn't use the fork
number and simply executed all tests sequentially. This shouldn't be a big
problem, be
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146299251
We do execute multiple tests concurrently (multiple forks). Does this lead
to problems when all forks see the fork number "1" ? I am wondering, because at
some place
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146277055
BTW, because your PR is based on your master branch, not topic branch, you
should [overwrite master branch in your
repository](http://stackoverflow.com/questions/1125
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1234#issuecomment-146275842
Hi @dawidwys, Thanks for opening pull request.
Your pull request looks good to merge. This PR will be merged in few days
if there is no objection.
---
If your pr
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/1234
[FLINK-2156] Scala modules cannot create logging file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dawidwys/flink master
Alternatively you
10 matches
Mail list logo
