[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-08 Thread gaborhermann
Github user gaborhermann commented on the pull request: https://github.com/apache/flink/pull/771#issuecomment-109909701 Of course. I took up the JIRA issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-08 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/771#issuecomment-109907919 Please open a PR with it. Could you give FLINK-2180 a try in the meantime please? It looks similar on paper. You can add then to the same pull request of course. :) --

[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-08 Thread gaborhermann
Github user gaborhermann commented on the pull request: https://github.com/apache/flink/pull/771#issuecomment-109894121 Thanks for merging. I removed the line that failed the test (I mistakenly checked a non-deterministic id). https://github.com/gaborhermann/flink/commits/FLINK-213

[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/771 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-06 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/771#issuecomment-109565755 The iteration test sometimes fails on travis, so removed that. https://travis-ci.org/mbalassi/flink/jobs/65594738 --- If your project is set up for it, you can repl

[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-05 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/771#issuecomment-109338790 Let me merge this for the release now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-04 Thread mbalassi
Github user mbalassi commented on a diff in the pull request: https://github.com/apache/flink/pull/771#discussion_r31766212 --- Diff: flink-staging/flink-streaming/flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/DataStreamTest.scala --- @@ -0,0 +1,475 @@

[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-04 Thread mbalassi
Github user mbalassi commented on a diff in the pull request: https://github.com/apache/flink/pull/771#discussion_r31766241 --- Diff: flink-staging/flink-streaming/flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/DataStreamTest.scala --- @@ -0,0 +1,475 @@

[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-04 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/771#issuecomment-108932396 @StephanEwen: The `SingleOutpustStreamOperator` has the returns method, similar to the batch API. --- If your project is set up for it, you can reply to this email and

[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-04 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/771#issuecomment-108927352 General questions: Are type hints implemented already in the streaming API? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-04 Thread gaborhermann
Github user gaborhermann commented on the pull request: https://github.com/apache/flink/pull/771#issuecomment-108902692 Fixed the style issues and added more tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request: [FLINK-2136] Adding DataStream tests for Scala...

2015-06-04 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/771#discussion_r31720473 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/operators/AbstractUdfStreamOperator.java --- @@