[GitHub] flink pull request: [FLINK-2115] [Table API] support no aggregatio...

2015-12-02 Thread ChengXiangLi
Github user ChengXiangLi closed the pull request at: https://github.com/apache/flink/pull/1377 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] flink pull request: [FLINK-2115] [Table API] support no aggregatio...

2015-12-02 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1377#issuecomment-161265693 Thanks for your efforts. :smile: Could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request: [FLINK-2115] [Table API] support no aggregatio...

2015-12-02 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1377#issuecomment-161235699 Hi, you are are absolutely right, I'm sorry. Please don't hesitate to ping me in the future if I'm taking to long but I'll also try to be more responsive on these.

[GitHub] flink pull request: [FLINK-2115] [Table API] support no aggregatio...

2015-12-01 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1377#issuecomment-161190371 Hi, @aljoscha , i guess you may forget this PR :smile: , could you help to move this forward? it should be ready yet. --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-2115] [Table API] support no aggregatio...

2015-11-19 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1377#issuecomment-158025348 @Li Chengxiang, you can always pull changes directly from the ASF git repository: https://git-wip-us.apache.org/repos/asf/flink.git. Then you don't have to wa

[GitHub] flink pull request: [FLINK-2115] [Table API] support no aggregatio...

2015-11-19 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1377#issuecomment-158007073 Ok, i think it could be added in the `Select` operator description in Table API page, it would depends on FLINK-2955. Seems it takes quite long time delay to sync

[GitHub] flink pull request: [FLINK-2115] [Table API] support no aggregatio...

2015-11-19 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1377#issuecomment-157997049 OK, I see your point. We can go with the MySQL way then. Thanks for explaining it. :smile: Could you please update the documentation with a small paragraph tha

[GitHub] flink pull request: [FLINK-2115] [Table API] support no aggregatio...

2015-11-18 Thread ChengXiangLi
Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/1377#issuecomment-157932844 @aljoscha , it's a very interesting topic, should we add a limitation that only allow key fields to be no aggregated function field in `select` clause? Oracle ha

[GitHub] flink pull request: [FLINK-2115] [Table API] support no aggregatio...

2015-11-18 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1377#issuecomment-157728542 What it does now is to only pick one element in the group that has the compound key of the `groupBy` expression. The reason why I did not want to support this initially

[GitHub] flink pull request: [FLINK-2115] [Table API] support no aggregatio...

2015-11-18 Thread ChengXiangLi
GitHub user ChengXiangLi opened a pull request: https://github.com/apache/flink/pull/1377 [FLINK-2115] [Table API] support no aggregation after groupBy. `JavaBatchTranslator` does not support no aggregation `select` after `groupBy` previously, add the logic in this PR. You can merg