[GitHub] flink pull request: [FLINK-2084] [core] Add an option to start Fli...

2015-05-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-2084] [core] Add an option to start Fli...

2015-05-26 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/718#discussion_r31029417 --- Diff: flink-dist/src/main/flink-bin/bin/jobmanager.sh --- @@ -80,7 +81,7 @@ case $STARTSTOP in rotateLogFile $out echo "

[GitHub] flink pull request: [FLINK-2084] [core] Add an option to start Fli...

2015-05-26 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/718#discussion_r31026871 --- Diff: flink-dist/src/main/flink-bin/bin/jobmanager.sh --- @@ -80,7 +81,7 @@ case $STARTSTOP in rotateLogFile $out echo "Sta

[GitHub] flink pull request: [FLINK-2084] [core] Add an option to start Fli...

2015-05-26 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/718#issuecomment-105502334 Thank you for the comments. I'll address them and merge this... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-2084] [core] Add an option to start Fli...

2015-05-26 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/718#discussion_r31026487 --- Diff: flink-dist/src/main/flink-bin/bin/jobmanager.sh --- @@ -80,7 +81,7 @@ case $STARTSTOP in rotateLogFile $out echo "

[GitHub] flink pull request: [FLINK-2084] [core] Add an option to start Fli...

2015-05-26 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/718#issuecomment-105462206 +1 looks solid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] flink pull request: [FLINK-2084] [core] Add an option to start Fli...

2015-05-26 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/718#discussion_r31016976 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/memory/MemoryManagerLazyAllocationTest.java --- @@ -0,0 +1,209 @@ +/* + * Licensed to the A

[GitHub] flink pull request: [FLINK-2084] [core] Add an option to start Fli...

2015-05-25 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/718#issuecomment-105230094 +1 to merge. The changes look good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] flink pull request: [FLINK-2084] [core] Add an option to start Fli...

2015-05-25 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/718#discussion_r30977601 --- Diff: flink-dist/src/main/flink-bin/bin/jobmanager.sh --- @@ -80,7 +81,7 @@ case $STARTSTOP in rotateLogFile $out echo "Sta

[GitHub] flink pull request: [FLINK-2084] [core] Add an option to start Fli...

2015-05-22 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/718 [FLINK-2084] [core] Add an option to start Flink in streaming mode The streaming mode subsumes the batch mode, as it allows to run both kinds of programs. Batch programs will most likely run slig