Github user gallenvara closed the pull request at:
https://github.com/apache/flink/pull/1035
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1035#issuecomment-133364252
A few more comments from my side:
- The class overrides `equals()` but `hashCode()` has been removes. This
is a classical bug.
- The `compareTo()` me
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1035#issuecomment-133340112
Hi @gallenvara, great to see that more and more new people join the Flink
community :-)
IMHO, whether a method is used from within the same class or not is
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1035#discussion_r37616089
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/Path.java ---
@@ -430,40 +296,127 @@ public int depth() {
}
/**
-
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1035#issuecomment-133315613
@tillrohrmann I'm new to Flink. Thanks for your words and if i have any
mistake please point it out.
My idea on this issue is :
the ```Path``` class has beco
Github user gallenvara commented on a diff in the pull request:
https://github.com/apache/flink/pull/1035#discussion_r37610286
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/Path.java ---
@@ -430,40 +296,127 @@ public int depth() {
}
/**
-*
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1035#issuecomment-132962489
@gallenvara, could you elaborate a little bit on why you've moved the
`makeQualified` method into the static `FileSystemUtil` class? What's the
benefit of it. Is th
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1035#discussion_r37512972
--- Diff: flink-core/src/main/java/org/apache/flink/core/fs/Path.java ---
@@ -430,40 +296,127 @@ public int depth() {
}
/**
-
Github user gallenvara commented on the pull request:
https://github.com/apache/flink/pull/1035#issuecomment-132482759
Hi, @zentol .Thanks for your review.
Remove two methods : hashCode() and compareTo()
---
If your project is set up for it, you can reply to this email and have yo
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1035#issuecomment-132481210
The changes i see are:
* removed hashCode()
* moved makeQualified to a new file as a static method
* reordered the remaining methods in Path
is that ab
GitHub user gallenvara opened a pull request:
https://github.com/apache/flink/pull/1035
[FLINK-2077] [core] Rework Path class and add extend support for Windows
paths
The class org.apache.flink.core.fs.Path handles paths for Flink's
FileInputFormat and FileOutputFormat. Over time,
11 matches
Mail list logo
