Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/716
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/716#issuecomment-105260996
Amazing, thank you.
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/716#issuecomment-105233972
@rmetzger I added tests for both SlidingTimePreReducer and
SlidingTimeGroupedPreReducer to verify that they correctly flush their states
after a burst of elements.
---
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/716#issuecomment-104708161
Thats actually a compelling case for adding a test.
Also it seems that you are planning to rework a lot of the windowing stuff
.. The more tests you have there, the
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/716#issuecomment-104706869
I don't know, all this time we had the wrong behaviour and no tests were
catching it.
---
If your project is set up for it, you can reply to this email and have your
re
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/716#issuecomment-104702211
Is there an easy way to add a test for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/716
[FLINK-2074] Fix erroneous emission of Sliding Time PreReducer
Before this, a sliding time window would keep emitting the last result
because the number of elements per pre-aggregation result was
