Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/663
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/663#issuecomment-102302338
Thanks for pinging.
I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/663#issuecomment-101972007
Guys,
Maybe it makes sense to merge this :)
It's been here for a while.
---
If your project is set up for it, you can reply to this email and have your
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/663#issuecomment-100543436
The annotations look good to me.
I think one more annotation could be added.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/663#discussion_r29996107
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -1329,6 +1355,7 @@ public void join(Tuple3>
keysWithEdge, Vertex ne
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/663#issuecomment-100544083
Indeed I was missing that annotation. Nice catch!
PR updated :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/663#issuecomment-100516246
Thx @andralungu, really appreciate it.
Usually JIRA issue describes what is the problem or task to do, and pull
request description should tell how and why certain ch
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/663#issuecomment-100372745
Sure @hsaputra ,
I thought the JIRA issue was descriptive enough. We were missing
ForwardedFields* annotations for the majority of Gelly classes in Graph.java
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/663#issuecomment-100370285
@andralungu , please add more description about the PR to help people
review and understand why this PR is made.
---
If your project is set up for it, you can reply to
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/663
[FLINK-1976][gelly] Added ForwardedFields Annotations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andralungu/flink fwdFields
Alternativel
10 matches
Mail list logo
