Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/666#issuecomment-100902145
Hey,
thank you for working on this & opening a pull request.
I'll address your comments inline:
> put the default value for queueSize attribute in a
Github user carloscurotto commented on a diff in the pull request:
https://github.com/apache/flink/pull/666#discussion_r30009100
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/twitter/PropertiesUtil.java
---
@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/666#discussion_r30004354
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/twitter/PropertiesUtil.java
---
@@ -0,
Github user carloscurotto commented on the pull request:
https://github.com/apache/flink/pull/666#issuecomment-100671079
Let me also suggest a few other further improvements:
TwitterSource:
- put the default value for queueSize attribute in a constant (we could
call i
GitHub user carloscurotto opened a pull request:
https://github.com/apache/flink/pull/666
[FLINK-1964] Rework TwitterSource to use a Properties object
I have changed TwitterSource and its related code to use a properties
object insted of a file path so we could inject properties fro
