[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1376 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1376#issuecomment-158042693 Merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1376#issuecomment-158016205 Great @zentol. Good to merge then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

Github user zentol commented on the pull request: https://github.com/apache/flink/pull/1376#issuecomment-158015146 @tillrohrmann I've changed the type deduction test to a) no longer produce any output and b) actually fail with an exception f things go wrong. --- If your project is se

[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1376#discussion_r45240517 --- Diff: flink-libraries/flink-python/src/test/python/org/apache/flink/python/api/test_type_deduction.py --- @@ -58,5 +58,5 @@ msg.output()

[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1376#discussion_r45227781 --- Diff: flink-libraries/flink-python/src/test/python/org/apache/flink/python/api/test_type_deduction.py --- @@ -58,5 +58,5 @@ msg.output()

[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1376#issuecomment-157772432 Changes look good. I had only a minor comment. Besides that +1 for merging. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1376#discussion_r45224052 --- Diff: flink-libraries/flink-python/src/test/python/org/apache/flink/python/api/test_type_deduction.py --- @@ -58,5 +58,5 @@ msg.outpu

[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1376#discussion_r45222496 --- Diff: flink-libraries/flink-python/pom.xml --- @@ -48,6 +48,14 @@ under the License. +

[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/1376#discussion_r45221988 --- Diff: flink-libraries/flink-python/pom.xml --- @@ -48,6 +48,14 @@ under the License. +

[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1376#discussion_r45221471 --- Diff: flink-libraries/flink-python/pom.xml --- @@ -48,6 +48,14 @@ under the License.

[GitHub] flink pull request: [FLINK-1945][py] Python Tests less verbose

GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/1376 [FLINK-1945][py] Python Tests less verbose Tests now extend from JavaProgramTestBase, were consolidated into less files to reduce build time, and restructured to not be utterly chaotic. You can merg