Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/635
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/635#issuecomment-102374179
This looks good! Thanks for the update @andralungu!
Will merge :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/635#issuecomment-99494248
PR updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/635#issuecomment-99169722
Yap, that's what I had in mind! Only the class names are a bit too long.
Maybe VertexCentricConfiguration and GSAConfiguration? Or something similar?
---
If your project is
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/635#issuecomment-99157184
Hi @vasia,
The alternatives to having a single config class for all types of
iterations are:
- having two separate classes in spargel and in gsa = massive
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/635#issuecomment-99076845
This looks good in general. The only issue we should consider is whether
having one IterationConfiguration type for both vertex-centric and GAS (and
probably other iteration
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/635
[FLINK-1942][gelly] GSA Iteration Configuration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andralungu/flink gsaConfig
Alternatively you
