[GitHub] flink pull request: [FLINK-1891]Add the input storageDirectory emp...

2015-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/601 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-1891]Add the input storageDirectory emp...

2015-04-21 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/601#issuecomment-94708399 I'm going to merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] flink pull request: [FLINK-1891]Add the input storageDirectory emp...

2015-04-17 Thread matadorhong
Github user matadorhong commented on a diff in the pull request: https://github.com/apache/flink/pull/601#discussion_r28594789 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java --- @@ -64,15 +64,19 @@ * @return the storage directory used by

[GitHub] flink pull request: [FLINK-1891]Add the input storageDirectory emp...

2015-04-16 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/601#issuecomment-93734377 Thanks for the PR. Looks good to me, except for a possible minor improvement. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] flink pull request: [FLINK-1891]Add the input storageDirectory emp...

2015-04-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/601#discussion_r28508734 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java --- @@ -64,15 +64,19 @@ * @return the storage directory used by a B

[GitHub] flink pull request: [FLINK-1891]Add the input storageDirectory emp...

2015-04-15 Thread matadorhong
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/601 [FLINK-1891]Add the input storageDirectory empty check Add the input storageDirectory empty check, if input of storageDirectory is empty, we should use tmp as the base dir And also fix the co