Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1915
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-216896889
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-216793718
Thanks for the update @stefanobortoli.
PR is good to merge once tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-216525073
@stefanobortoli yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user stefanobortoli commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-216521677
@tillrohrmann, I see the conflicts. How should I deal with this? rebase?
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/1915#discussion_r61855824
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/util/StartupUtils.java ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Softw
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-216475737
Modulo one more inline comment, I think it looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1915#discussion_r61855640
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/util/StartupUtils.java ---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Softwar
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-216474116
Is this good to merge, @tillrohrmann?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-215342703
@rmetzger said that it is related to corrupt cache files and that
refreshing the caches would help. I think @uce already contacted INFRA to do
that. Hopefully, this
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-215201773
Any idea what might be causing the error in FlinkML? I can't pinpoint it to
any specific source file.
---
If your project is set up for it, you can reply to this emai
Github user stefanobortoli commented on a diff in the pull request:
https://github.com/apache/flink/pull/1915#discussion_r61037816
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerStartupTest.java
---
@@ -53,41 +59,55 @@ public void testStartup
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1915#discussion_r60942417
--- Diff: flink-test-utils/pom.xml ---
@@ -7,9 +7,7 @@ regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Versi
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-214425488
Thanks for your contribution @stefanobortoli :-) I think the changes look
good and can be merged.
---
If your project is set up for it, you can reply to this email
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1915#discussion_r60940770
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskManagerStartupTest.java
---
@@ -53,41 +59,55 @@ public void testStartupWh
Github user fpompermaier commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-212390687
With this last commit we improved test stability. With respect to other PR
(that fails in all configuration) this PR fails only in the last one, when
compiling **fl
Github user stefanobortoli commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-212305774
We had a look at the Flink test dependency hierarchies and the thing is
feasible but I it should be done in a separate PR. In fact, it requires a
clerical review
Github user stefanobortoli commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-212293101
We mainly wanted to simplify the build skipping tests. However, if you
think it makes sense, we can give it a try.
---
If your project is set up for it, you can
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1915#issuecomment-212076850
I quickly scrolled over the changed, and overall I like the idea of fixing
the thing with the test utils.
I wonder if we could get rid of the "flink-test-utils" enti
GitHub user stefanobortoli opened a pull request:
https://github.com/apache/flink/pull/1915
Flink 1827 and small fixes in some tests
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your chang
20 matches
Mail list logo
