Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/566
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/566#issuecomment-103240648
Looks good. I'll adapt a few things and will merge the PR tomorrow.
Thanks for improving the CSV parsers and making them more consistent.
---
If your project is set u
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r30540219
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/ByteParser.java ---
@@ -21,22 +21,23 @@
public class ByteParser extends Field
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/566#issuecomment-103038656
Thanks for the update! I'll have a look at it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user FelixNeutatz commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r29148302
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/IntParser.java ---
@@ -38,19 +38,28 @@ public int parseField(byte[] bytes, int startPos,
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r29147205
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/IntParser.java ---
@@ -38,19 +38,28 @@ public int parseField(byte[] bytes, int startPos, int
Github user FelixNeutatz commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r29145755
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/IntParser.java ---
@@ -38,19 +38,28 @@ public int parseField(byte[] bytes, int startPos,
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/566#issuecomment-96647676
Looks good. I added few minor comments inline.
Did you check if the changes should also go into the `ByteParser`?
---
If your project is set up for it, you can reply
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r29144391
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/IntParser.java ---
@@ -38,19 +38,28 @@ public int parseField(byte[] bytes, int startPos, int
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r29143800
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/DoubleParser.java ---
@@ -42,6 +42,15 @@ public int parseField(byte[] bytes, int startPos, int
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r29143814
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FloatParser.java ---
@@ -102,6 +111,10 @@ public static final float parseField(byte[] bytes, i
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r29143809
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FloatParser.java ---
@@ -41,6 +41,15 @@ public int parseField(byte[] bytes, int startPos, int
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r29143763
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/DoubleParser.java ---
@@ -103,6 +112,10 @@ public static final double parseField(byte[] bytes,
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r29143622
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java
---
@@ -353,6 +354,99 @@ public void testIntegerFieldsl() throws IOExc
Github user FelixNeutatz commented on the pull request:
https://github.com/apache/flink/pull/566#issuecomment-94810290
@fhueske: I agree on that :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/566#issuecomment-94722728
It would also be good to extend the respective parser tests such as
`IntParserTest` when changing the behavior and semantics of the parsers.
---
If your project is set up
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/566#issuecomment-94722161
Your PR changes the semantics of the Integer parsers a bit because you
ignore whitespaces. This change has a few implications. The following fields
are parsed as correct I
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610833
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/DoubleParser.java ---
@@ -42,6 +42,10 @@ public int parseField(byte[] bytes, int startPos, int
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610838
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FloatParser.java ---
@@ -41,6 +41,10 @@ public int parseField(byte[] bytes, int startPos, int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610575
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/LongParser.java ---
@@ -33,6 +33,19 @@ public int parseField(byte[] bytes, int startPos, int
limi
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610548
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/DoubleParser.java ---
@@ -49,7 +53,7 @@ public int parseField(byte[] bytes, int startPos, int
lim
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610571
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/IntParser.java ---
@@ -37,7 +37,20 @@ public int parseField(byte[] bytes, int startPos, int
limit
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610577
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/ShortParser.java ---
@@ -36,7 +36,20 @@ public int parseField(byte[] bytes, int startPos, int
lim
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/566#discussion_r28610554
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/FloatParser.java ---
@@ -48,7 +52,7 @@ public int parseField(byte[] bytes, int startPos, int
limi
24 matches
Mail list logo
