Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/582
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/582#issuecomment-94919453
Yo, looks fine now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/582#issuecomment-94799103
So, any thoughts about merging this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/582#issuecomment-94483743
I fixed @StephanEwen's complaint. It was incorrect but the type class of
TypeInformation does not seem to be used in any places where it matters.
---
If your project is
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/582#discussion_r28692599
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/ObjectArrayTypeInfo.java
---
@@ -143,6 +143,18 @@ else if (type instanceof Class && ((
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/582#discussion_r28691764
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/ObjectArrayTypeInfo.java
---
@@ -143,6 +143,18 @@ else if (type instanceof Class &&
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/582#issuecomment-94392757
Any more thoughts? Otherwise I would like to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/582#issuecomment-93980529
I added the test case @tillrohrmann suggested. Also helped me find a bug.
:relieved:
---
If your project is set up for it, you can reply to this email and have your
repl
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/582#issuecomment-93929395
Maybe we could add in the test case the case where we have an ```Object```
array. Other than that LGTM.
---
If your project is set up for it, you can reply to this e
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/582#issuecomment-92381429
Any more comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/582#issuecomment-91327192
Instead of the switch/case statement, can't you use
`PrimitiveArrayTypeInfo.getInfoFor(Class type)`? Seems simpler.
Also, this is a good change to be backed by
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/582
[FLINK-1799][scala] Fix handling of generic arrays
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink fix-scala-generic-arrays
Alte
12 matches
Mail list logo
