Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/511#issuecomment-88183433
LGTM. Will merge later today. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user matadorhong commented on the pull request:
https://github.com/apache/flink/pull/511#issuecomment-86050415
@StephanEwen I have fixed the code style issue and changed the PR to an
"Improvement" one in jira.
Finally, great thanks for your help. And I will take more time to
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/511#issuecomment-84494016
No problem. We are happy that you are interested to contribute :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user matadorhong commented on the pull request:
https://github.com/apache/flink/pull/511#issuecomment-84491491
Thanks for Ewen. That help me a lot to understand how to contribute to
Flink. I will follow the guide in the future.
---
If your project is set up for it, you can rep
Github user matadorhong commented on the pull request:
https://github.com/apache/flink/pull/511#issuecomment-84489355
Great thanks to Ewen. I will first have a study of how to format code. Then
pull a request.
---
If your project is set up for it, you can reply to this email and have
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/511#issuecomment-84423950
If you are interested: Here are some simple guidelines on how to format
code and create easy to merge commits for pull requests:
http://flink.apache.org/codin
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/511#issuecomment-84423820
Looks good. This seems more like an optimization, than a bug,
Before we can merge the change, it needs to be brought in sync with the
code style. Currently, th
Github user matadorhong closed the pull request at:
https://github.com/apache/flink/pull/509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/511
[FLINK-1766]Fix the bug of equals function of FSKey
The equals function in org.apache.flink.core.fs.FileSystem.FSKey should
first confirm whether obj == this, if obj is the same object.It should
GitHub user matadorhong opened a pull request:
https://github.com/apache/flink/pull/509
[FLINK-1766]Fix the bug of equals function of FSKey
The equals function in org.apache.flink.core.fs.FileSystem.FSKey should
first confirm whether obj == this, if obj is the same object.It should
11 matches
Mail list logo
