Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/576
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/576#issuecomment-96271897
Hey @andralungu!
I see your point regarding `iterateOn...` and `reduce...`. Let's leave it
like this for now.
Only small thing that maybe I didn't explain well, is "o
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/576#issuecomment-94572014
Apart from the fact that I don't agree with those two methods having the
same name, everything else was updated.
---
If your project is set up for it, you can reply t
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/576#issuecomment-94461019
Hi @vasia ,
The inline comments have been addressed, I still have the big comment to
look at :)
One thing(or two ^^) that could be discussed:
- th
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/576#issuecomment-93996607
Hi @andralungu! Thanks for the quick update ^^
The result looks good, but I have a few more comments/suggestions (apart
from the inline ones).
- +1 for the `grou
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/576#discussion_r28594561
--- Diff: docs/gelly_guide.md ---
@@ -316,28 +327,49 @@ DataSet> verticesWithSum =
graph.reduceOnNeighbors(
new SumValues(), Edge
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/576#discussion_r28595115
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/EdgeDirection.java
---
@@ -20,10 +20,10 @@
/**
* The EdgeDirection is
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/576#discussion_r28594425
--- Diff: docs/gelly_guide.md ---
@@ -282,25 +290,28 @@ The following code will collect the out-edges for
each vertex and apply the `Sel
{% highlight java %
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/576#discussion_r28594318
--- Diff: docs/gelly_guide.md ---
@@ -282,25 +290,28 @@ The following code will collect the out-edges for
each vertex and apply the `Sel
{% highlight java %
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/576#discussion_r28594064
--- Diff: docs/gelly_guide.md ---
@@ -269,7 +269,15 @@ Neighborhood Methods
Neighborhood methods allow vertices to perform an aggregation on their
fir
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/576#issuecomment-92270780
Hello @vasia ,
I updated the PR to use reduce where possible(for the functions which
return one value per vertex).
Let me know if there is anything I missed
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/576#issuecomment-90749788
Thanks for the PR @andralungu!
The idea for this issue is to (a) use a combinable reduce for the simple
(without vertex value) reduceOn* methods, because it will be
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/576
[FLINK-1758][gelly] Neighborhood Methods Extensions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andralungu/flink extendNeighborhood
Alter
13 matches
Mail list logo
