[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...

2015-03-19 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/499#issuecomment-83660699 Merged. Thank you for the patch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...

2015-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/499 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...

2015-03-19 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/499#issuecomment-83452300 Good, will merge this in the next batch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...

2015-03-18 Thread matadorhong
Github user matadorhong commented on the pull request: https://github.com/apache/flink/pull/499#issuecomment-83238963 Have modified the port range of TaskManager in [0, 65535] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...

2015-03-18 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/499#issuecomment-83150196 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...

2015-03-18 Thread matadorhong
Github user matadorhong commented on a diff in the pull request: https://github.com/apache/flink/pull/499#discussion_r26695073 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -1274,9 +1274,10 @@ object TaskManager {

[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...

2015-03-18 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/499#discussion_r26690147 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -1274,9 +1274,10 @@ object TaskManager {

[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...

2015-03-18 Thread hsaputra
Github user hsaputra commented on a diff in the pull request: https://github.com/apache/flink/pull/499#discussion_r26686143 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala --- @@ -1274,9 +1274,10 @@ object TaskManager { "'

[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...

2015-03-18 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/499#issuecomment-83065881 Looks good. +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] flink pull request: [FLINK-1739]Fix the bug of JobManager and Task...

2015-03-18 Thread matadorhong
GitHub user matadorhong opened a pull request: https://github.com/apache/flink/pull/499 [FLINK-1739]Fix the bug of JobManager and TaskManager Port Check. The IPC port of JobManager and IPC port of TaskManager must be great than 0 and less than 65535. It must have check the port