[GitHub] flink pull request: [FLINK-1735] Feature Hasher

Github user ChristophAl commented on the pull request: https://github.com/apache/flink/pull/665#issuecomment-116517528 Hi, after I rebased it on master and implemented the new pipeline interface, I have some followup questions regarding the types we should accept for feature

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

Github user aalexandrov commented on the pull request: https://github.com/apache/flink/pull/665#issuecomment-106914608 @FelixNeutatz I think this needs to be squashed before mergning as well. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] flink pull request: [FLINK-1735] Feature hasher

Github user FelixNeutatz closed the pull request at: https://github.com/apache/flink/pull/661 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-1735] Feature hasher

Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/661#issuecomment-100690583 This will be further implemented here: https://github.com/apache/flink/pull/665 --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

Github user FelixNeutatz commented on a diff in the pull request: https://github.com/apache/flink/pull/665#discussion_r30005430 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala --- @@ -0,0 +1,142 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

Github user aalexandrov commented on the pull request: https://github.com/apache/flink/pull/665#issuecomment-100685242 Nice job! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

Github user aalexandrov commented on a diff in the pull request: https://github.com/apache/flink/pull/665#discussion_r30005092 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala --- @@ -0,0 +1,142 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

Github user aalexandrov commented on a diff in the pull request: https://github.com/apache/flink/pull/665#discussion_r30005080 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala --- @@ -0,0 +1,142 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

Github user aalexandrov commented on a diff in the pull request: https://github.com/apache/flink/pull/665#discussion_r30005062 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala --- @@ -0,0 +1,142 @@ +/* + * Licensed

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

Github user aalexandrov commented on a diff in the pull request: https://github.com/apache/flink/pull/665#discussion_r30004988 --- Diff: flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/feature/extraction/FeatureHasherSuite.scala --- @@ -0,0 +1,245 @@ +/* + * Lice

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

GitHub user ChristophAl opened a pull request: https://github.com/apache/flink/pull/665 [FLINK-1735] Feature Hasher The prototype of the feature hasher. - The implementation is based on the scikit-learn feature hasher - Test vectors have been generated by scikit-learn as