[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...

2015-02-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...

2015-02-20 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/424#issuecomment-75330500 I was thinking as high as a minute to have as a limit. But after reconsidering it I am for your argument, trying to establish the connection every couple of seconds shoul

[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...

2015-02-19 Thread qmlmoon
Github user qmlmoon commented on the pull request: https://github.com/apache/flink/pull/424#issuecomment-75197699 As a user I would expect the system could carry on quickly after server socket is reinitiated. A large limit of exponentially increase may lead to potential long wait and

[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...

2015-02-19 Thread chiwanpark
Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/424#issuecomment-75186840 +1 for exponentially increasing wait time --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...

2015-02-19 Thread mbalassi
Github user mbalassi commented on the pull request: https://github.com/apache/flink/pull/424#issuecomment-75153547 Thanks for quickly picking out the issue. Looks good to me I might modify it to exponentially increase wait time until a limit instead of constant 5 seconds. What do you

[GitHub] flink pull request: [FLINK-1582][streaming]Allow SocketStream to r...

2015-02-19 Thread qmlmoon
GitHub user qmlmoon opened a pull request: https://github.com/apache/flink/pull/424 [FLINK-1582][streaming]Allow SocketStream to reconnect when socket closes You can merge this pull request into a Git repository by running: $ git pull https://github.com/qmlmoon/incubator-flink