Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73749137
Thanks @balidani.
And travis tests now pass :tada:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73732358
@vasia my ICLA has been filed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73694315
Ha! Thanks :))
On Feb 10, 2015 1:10 PM, "zentol" wrote:
> in the pom.xml in flink-gelly; change flink-addons to flink-staging
>
> â
> Reply to this
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73689455
in the pom.xml in flink-gelly; change flink-addons
to flink-staging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73688058
I'm getting the following error on travis:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.12.1:check (validate) on
project fli
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73547684
Simple renaming didn't seem to keep the history, so I did the filtering
again :)
Didn't you have the same problem when moving flink-addons to flink-staging?
Let
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73499086
@vasia: You don't need to open a new pull request, force pushing to the
branch this PR is based on will update it.
I don't know if you need to do the history filtering
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73434977
Great, thanks ^^
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73434866
@vasia yes, just submitted mine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73434636
@rmetzger does this mean I need to do the history filtering magic again and
open a new pr?
@andralungu thanks a lot!
@balidani have you submitted yours?
---
If your
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73381932
I got the ACK from Apache. My ICLA has been filed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-73366441
I'm really sorry that I've messed up this pull request by renaming
"flink-addons" to "flink-staging" :(
I was doing it in a rush Really sorry.
---
If your projec
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72883525
@balidani that's OK :)
@cebe we've got the acknowledgement for you, thanks!
@andralungu has submitted hers today.
---
If your project is set up for it, you can repl
Github user balidani commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72851434
Sorry, I will only be able to fill the form on Sunday, my internet
connection is horrible here. Is that ok?
Daniel
On Feb 2, 2015 3:53 PM, "Carsten Brandt"
Github user cebe commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72469660
> @cebe: could you please complete and sign this form (if you haven't
already)? Thank you!
done.
---
If your project is set up for it, you can reply to this email a
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72390331
Good catch, Fabian. Yes, please do submit ICLA to secretary before we could
continue.
On Sunday, February 1, 2015, Vasia Kalavri wrote:
> Right, than
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72372857
Right, thanks @fhueske for bringing this up!
@balidani, @andralungu, @cebe: could you please complete and sign [this
form](https://www.apache.org/licenses/icla.pdf) (if y
Github user cebe commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72366683
I see, did not know about this. thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72366621
This is not about the license of the software / code itself. The [ASF
homepage](http://www.apache.org/licenses/#clas) says
> The ASF desires that all contributors
Github user cebe commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72366219
@fhueske why is that needed? [Gelly is Apache
2.0](https://github.com/project-flink/flink-graph/blob/master/LICENSE) licensed
and Flink too: https://github.com/apache/flink/b
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-72359922
One more thing ;-)
Did we collect ICLAs from all people contributing significant parts to
Gelly?
---
If your project is set up for it, you can reply to this email and
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71507264
Tests renamed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71494713
Alright, thanks @fhueske! So, it seems all of our tests are integration
test cases. I will update later today I hope :)
---
If your project is set up for it, you can reply
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71492121
Sure, XyzTest are unit tests which are executed in Maven's test phase.
These should execute rather fast. Everything that brings up a full Flink system
is an integration te
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71491484
No worries, I can rename the tests. It's better to be consistent :)
May I ask, what is the difference between a XyzTest and a XyzITCase test
though? Thnx!
---
If your p
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71465448
Haven't had a closer look yet, but one thing that I noticed is the naming
of the test files.
In the current codebase all tests are named XyzTest (or XyzITCase) instead
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/335#issuecomment-71376640
Thank you.
Looks good. History is preserved and you addressed my comments.
+1 for merging it.
---
If your project is set up for it, you can reply to this ema
Github user vasia closed the pull request at:
https://github.com/apache/flink/pull/326
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-71344479
Yosh! Managed to preserve history and fixed the package name:
https://github.com/vasia/flink/commits/gelly-with-history
I'm also addressing @rmetzger's comments (missing
Github user cebe commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-71268972
that really sounds like great fun :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-71230743
Ah, sorry, I forgot that, let me do that in a few hours. I am sort of
having fun with git right now :-)
FYI: What I basically used is the git filter-branch com
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-71204417
Yes. The package seems to be still wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-71181165
Thanks a lot for looking into this @StephanEwen !
Can you share more details on how you did the filtering? Might be useful
for next time :)
Shouldn't the directo
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-71157010
I took the pull request and filtered the branch to move the files into the
`flink-addons/flink-gelly` directory (that worked better for me than the
subtree merge). Al
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70839009
Thank you all for the suggestions regarding preserving the commit history!
I'll try them out later today and see whether I can make it :)
---
If your project is set up for
Github user cebe commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70813345
> As for the merging / rebasing:
Can't you just import it using git subtree merge?
---
If your project is set up for it, you can reply to this email and have your
re
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70809957
Awesome work Vasia. +1 for Gelly and the personalized names. If we document
that Gelly is our graph API, then it shouldn't be a problem understand what it
is.
---
I
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70803368
I would like to respect Vasia's suggestion for the library name - she has
bootstrapped the whole thing, after all.
Personalized names are actually something
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70796718
+1 for Gelly :)
It's good to personalize flink libraries somehow, people remember these.
Though, to be honest, it would be more consistent in that case if oth
Github user ktzoumas commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70767467
I think Gelly has way more personality than flink-graph
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70759342
I'm very exited about this :-) I will have a look later as well.
Regarding the name: I like the name gelly, but would also prefer
flink-graph (or something along the l
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70744282
I also prefer flink-graph.
After having a quick look at the commits I would suggest to squash a couple
of them, e. g. fda6e4c, which is empty or 393902c which deletes
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70743431
Woot! :)
As for merging the streaming back then, it was @StephanEwen who came up
with the solution, pasting the important parts here:
"
BTW: I used t
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70740654
Regarding the name: I would actually vote to call it "flink-graph".
Mh, back then @mbalassi and @gyfora figured it out the last time. Maybe
they can remember how
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70725539
Hi @rmetzger! Thanks for starting on it so fast ^^
Regarding the name, we thought it'd be nice to have one.. It was actually
@ktzoumas that came up with Gelly :)
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/326#discussion_r23252081
--- Diff:
flink-addons/flink-gelly/src/main/java/org/apache/flink/gelly/Edge.java ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundat
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/326#discussion_r23248831
--- Diff:
flink-addons/flink-gelly/src/test/java/org/apache/flink/gelly/test/TestWeaklyConnected.java
---
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the A
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/326#issuecomment-70717064
Great, I'm super excited to see the graph API being offered to the main
project.
I'll start reviewing the code right away, to merge it as soon as possible.
On
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/326
[FLINK-1201] Add flink-gelly to flink-addons
This PR adds an initial version of Gelly, a graph API for Flink, to the
flink-addons project.
The development of Gelly took place as a collaboration on
50 matches
Mail list logo
