[GitHub] flink issue #6233: [FLINK-9696] Deep toString for array/map sql types

2018-07-02 Thread snuyanzin
Github user snuyanzin commented on the issue: https://github.com/apache/flink/pull/6233 @hequn8128 thank you for your idea about Row. I used it in tests. Also I checked usages of `org.apache.flink.table.client.cli.CliStrings#NULL_COLUMN` it was added only recently and used only in Cli

[GitHub] flink issue #6233: [FLINK-9696] Deep toString for array/map sql types

2018-07-01 Thread snuyanzin
Github user snuyanzin commented on the issue: https://github.com/apache/flink/pull/6233 Hello @hequn8128! Thank you for your review and comments. About PR template - I did changes based on proposed #5811. Please let me know if it is acceptable or not. About `rowToString` agree.

[GitHub] flink issue #6233: [FLINK-9696] Deep toString for array/map sql types

2018-07-01 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6233 Hi @snuyanzin , thanks for your PR. The code looks good and the `deepToString()` function returns result correctly. I could not spot any issues with the implementation. To make the PR better, I thi